Add an explanation guide for librarian storage#545
Open
lgp171188 wants to merge 5 commits into
Open
Conversation
FinnRG
approved these changes
Jun 25, 2026
skyrmi
reviewed
Jun 30, 2026
skyrmi
approved these changes
Jun 30, 2026
odadacharles
requested changes
Jul 3, 2026
odadacharles
left a comment
odadacharles
left a comment
Collaborator
There was a problem hiding this comment.
Left quite a few comments and suggestions. Overall, this is very well explained and actually made it easy for me to understand the Librarian. Most of the comments and suggestions are more about improving clarity and using the right voice.
lgp171188
commented
Jul 3, 2026
lgp171188
force-pushed
the
add-explanation-doc-librarian
branch
from
f4946b3 to
4445115
Compare
odadacharles
approved these changes
Jul 3, 2026
odadacharles
left a comment
odadacharles
left a comment
Collaborator
There was a problem hiding this comment.
A few minor issues, otherwise, looks good to me.
|
|
||
| - The numeric ID used to determine a file's location. | ||
| - Multiple cryptographic hashes of the file's contents. | ||
| - The file size. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - The file size. | |
| - The file size |
Collaborator
Author
There was a problem hiding this comment.
I added the trailing full stop for the sake of consistency because the items above have it. Removing it feels odd to me.
…-launchpad/librarian.rst Co-authored-by: odadacharles <charles.odada@canonical.com>
…-launchpad/librarian.rst Co-authored-by: odadacharles <charles.odada@canonical.com>
…-launchpad/librarian.rst Co-authored-by: odadacharles <charles.odada@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make linkcheck-discretelocally to confirm new or edited linkswill pass the linkcheck CI.