feat: [WD-34728] Storage driver custom select#1916
Merged
Kxiru merged 1 commit intocanonical:mainfrom Apr 16, 2026
Merged
Conversation
Demo
Jenkins 
demos.haus 
Kxiru
force-pushed
the
storage-custom-select
branch
from
42f2e86 to
7634023
Compare
edlerd
reviewed
Apr 3, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Good start, some ideas to refine the changes below.
omarelkashef
reviewed
Apr 7, 2026
Contributor
omarelkashef
left a comment
omarelkashef
left a comment
There was a problem hiding this comment.
Thank you for the PR. A few comments below
Kxiru
force-pushed
the
storage-custom-select
branch
2 times, most recently
from
4d45bde to
db7458f
Compare
Kxiru
force-pushed
the
storage-custom-select
branch
from
db7458f to
fabdf29
Compare
omarelkashef
reviewed
Apr 8, 2026
Contributor
omarelkashef
left a comment
omarelkashef
left a comment
There was a problem hiding this comment.
Thank you for the iteration. It looks nearly perfect, but I think it broke some tests.
edlerd
reviewed
Apr 8, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Mostly LGTM, tiny nitpicks below.
Kxiru
force-pushed
the
storage-custom-select
branch
from
fabdf29 to
2051446
Compare
edlerd
previously approved these changes
Apr 9, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
QA LGTM, some tiny nitpicks below, then good to merge 👍
Kxiru
force-pushed
the
storage-custom-select
branch
2 times, most recently
from
12e12ce to
955dc7a
Compare
Kxiru
force-pushed
the
storage-custom-select
branch
2 times, most recently
from
51c980a to
30e13bc
Compare
edlerd
reviewed
Apr 10, 2026
Kxiru
force-pushed
the
storage-custom-select
branch
from
30e13bc to
3321293
Compare
edlerd
previously approved these changes
Apr 10, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
LGTM, thanks for the iterations :)
Collaborator
|
I think this breaks some of the tests though, can you check the CI results for new errors related to the changes in here? |
Kxiru
force-pushed
the
storage-custom-select
branch
from
3321293 to
80e9fd8
Compare
Contributor
Author
|
@edlerd I think tests should be looking good from now (storage wise) |
Collaborator
The 5.21 tests are still failing with storage bucket errors. I think that is due to changes in this PR. |
Kxiru
force-pushed
the
storage-custom-select
branch
3 times, most recently
from
d587c44 to
7160125
Compare
Kxiru
force-pushed
the
storage-custom-select
branch
4 times, most recently
from
ac7969f to
b1d39d9
Compare
edlerd
reviewed
Apr 16, 2026
Collaborator
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
two ideas to simplify this further.
Kxiru
force-pushed
the
storage-custom-select
branch
from
b1d39d9 to
7ad6c17
Compare
Signed-off-by: Nkeiruka <nkeiruka.whenu@canonical.com>
Kxiru
force-pushed
the
storage-custom-select
branch
from
7ad6c17 to
289fa4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
QA
Screenshots
Read only output field usage:
Help text specification for the storage drivers that require storage appliances:
