Repository navigation
[MISC] Improve test_upgrade.py resiliency - #215
Merged
Merged
Conversation
astrojuanlu
commented
Aug 29, 2026
astrojuanlu
commented
Aug 29, 2026
astrojuanlu
commented
Aug 29, 2026
Contributor
Author
|
There's 1 last reliability issue that seems deeply connected with the charm-refresh mechanism. Still investigating, asked for some help. |
Contributor
Author
|
Spoke with @carlcsaposs-canonical about the failure seen in https://github.com/canonical/mysql-router-operators/actions/runs/33254161600/job/99106512102?pr=215. It's difficult to say for certain because of juju/juju#19874 but it looks like some of the units aren't getting events towards the end of the test. And yet, charm-refresh is setting the databag correctly. I'll keep an eye on this test and if it happens more times I'll report to Juju. |
astrojuanlu
marked this pull request as ready for review
August 31, 2026 08:46
astrojuanlu
requested review from
Soundarya03,
paulomach and
sinclert-canonical
August 31, 2026 08:47
sinclert-canonical
left a comment
sinclert-canonical
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Only blocking comment is the one about the standardization of raised exceptions.
Assisted-by: OpenRouter:z-ai/glm-5.2 opencode
Assisted-by: OpenRouter:z-ai/glm-5.2 opencode
Assisted-by: OpenRouter:z-ai/glm-5.2 opencode
astrojuanlu
force-pushed
the
juanlu/8.4/upgrade-tests-resiliency
branch
from
September 16, 2026 08:28
06bfd98 to
b30c6af
Compare
Assisted-by: OpenRouter:z-ai/glm-5.3 pi
sinclert-canonical
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on porting canonical/mysql-operators#471 to here, I noted that
test_upgrade.pywas already very unstable. In fact, it's been consistently failing in the past few days:Locally the failure rate was similar, which was obviously disrupting my ability to test the new changes. So I'm pushing this first.
I also re-generated the
poetry.lockfiles, needed after we merged #62.