Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip documentation jobs if discourse credentials are not defined #463

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Nov 5, 2024

Applicable spec:

Overview

Fixes #400

Rationale

Workflow Changes

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@arturo-seijas arturo-seijas marked this pull request as ready for review November 5, 2024 11:22
@arturo-seijas arturo-seijas requested a review from a team as a code owner November 5, 2024 11:22
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind filling out the PR checklist next time please? :D
Also would it help to error out if the API username and API key is not defined? The current implementation may just skip the workflow which I'm not sure is desired :)

@arturo-seijas arturo-seijas merged commit bf83e41 into main Nov 5, 2024
77 checks passed
@arturo-seijas arturo-seijas deleted the skip-docs-steps-if-no-credentials branch November 5, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promote-charm: doc-automation-disabled unexpectedly requires Discourse creds
3 participants