Skip to content

[BugFix] Fix match image logging#171

Merged
douglasdotc merged 5 commits intomainfrom
fix-match-image-logging
Feb 4, 2026
Merged

[BugFix] Fix match image logging#171
douglasdotc merged 5 commits intomainfrom
fix-match-image-logging

Conversation

@fernando79513
Copy link
Contributor

Description

This PR broke logging of failed match images. When moving the logging from "match_text" to "find_text", we stopped logging images when the match failed, which is very usefull. This PR addresses this with the new behavior:

  • Failed match_text log the image once after all the retires
  • If a Region is provided, we log the cropped image too
  • We still log the several text matches if the DEBUG flag is set to true

Resolved issues

N/A

Documentation

Tests

Yarf test with several scenarios
log.html

@fernando79513 fernando79513 changed the title Fix match image logging (BugFix) [BugFix] Fix match image logging Feb 4, 2026
@github-actions github-actions bot changed the title [BugFix] Fix match image logging [BugFix] Fix match image logging Feb 4, 2026
@douglasdotc douglasdotc merged commit e70acc3 into main Feb 4, 2026
6 checks passed
@douglasdotc douglasdotc deleted the fix-match-image-logging branch February 4, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants