Skip to content

[New] Connection Error YARF exit code#176

Merged
p-gentili merged 13 commits intomainfrom
exit-code
Feb 18, 2026
Merged

[New] Connection Error YARF exit code#176
p-gentili merged 13 commits intomainfrom
exit-code

Conversation

@douglasdotc
Copy link
Collaborator

@douglasdotc douglasdotc commented Feb 6, 2026

Description

This PR adds YARF custom exit code for platform connection error.

Resolved issues

https://warthogs.atlassian.net/browse/YARF-60
closes #86

Documentation

Tests

douglasdotc and others added 3 commits February 6, 2026 13:24
Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
@douglasdotc douglasdotc marked this pull request as ready for review February 6, 2026 13:36
@douglasdotc douglasdotc requested a review from p-gentili February 6, 2026 13:36
Copy link
Collaborator

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the issue, but IMHO we should take a different direction because we definitely don't want to deal with RF lifecycle (see comment below).

I think for once we should ask for permission rather than forgiveness, adding a simple check_connection function in each platform that we run before even starting the suite. We don't want this to be a breaking change, hence please make the base method a simple logger.warning("Not implemented at platform level"); return True.

Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
@douglasdotc douglasdotc requested a review from p-gentili February 6, 2026 17:35
Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
Copy link
Collaborator

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still hiding something below, for instance in Vnc we have yield inside the try/except block, which makes it catch exceptions raised by the user, not the connection function. Now that we added the synchrounous connection test, which runs immediately before starting the test suite, I would recommend to revert those try/except blocks inside the libraries.

Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
douglasdotc and others added 6 commits February 16, 2026 16:38
Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
Signed-off-by: Douglas Chiang <douglasdothnc@gmail.com>
Copy link
Collaborator

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for all the changes, this is good to go!

@p-gentili p-gentili merged commit c91a034 into main Feb 18, 2026
6 checks passed
@p-gentili p-gentili deleted the exit-code branch February 18, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please create a custom exit code for non-test based failures

2 participants

Comments