Skip unreachable nodes in get_vms instead of failing#15
Open
kovalevsky wants to merge 1 commit intocanvrno:mainfrom
Open
Skip unreachable nodes in get_vms instead of failing#15kovalevsky wants to merge 1 commit intocanvrno:mainfrom
kovalevsky wants to merge 1 commit intocanvrno:mainfrom
Conversation
When a node is offline, proxmox.nodes(node).qemu.get() throws a connection error that bubbles up and fails the entire get_vms call. Wrap the per-node VM query in try/except so offline nodes are skipped gracefully while VMs on reachable nodes are still returned.
markmcjr
pushed a commit
to markmcjr/ProxmoxMCP
that referenced
this pull request
Feb 15, 2026
- Remove execute_vm_command MCP tool registration (arbitrary code execution risk) - Add environment variable auth (PROXMOX_HOST, PROXMOX_TOKEN_ID, PROXMOX_TOKEN_SECRET) - Add input validation for node names and VM IDs - Enable SSL verification by default in config.example.json - Fix Python version requirement to >=3.10 (MCP SDK needs it) - Fix MCP dependency: replace broken git+ URL with mcp>=1.0.0,<1.7.0 - Add main() entry point and __main__.py for python -m invocation - Wrap per-node VM listing in try/except (offline nodes no longer crash) - Fix test imports and assertions to match hardened codebase - Add SETUP.md with complete configuration and continuation docs Based on community PRs canvrno#14 and canvrno#15 plus additional security hardening. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a single offline node caused the entire
get_vmstool to fail with595 No route to host.qemu.get()call in try/except so offline/unreachable nodes are skipped gracefully