Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The spaceless tag is deprecated #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sumuhire
Copy link

@sumuhire sumuhire commented Jan 3, 2020

The spaceless tag is deprecated in Twig 2.7. Use the spaceless filter instead or {% apply spaceless %} (the Twig\Node\SpacelessNode and Twig\TokenParser\SpacelessTokenParser classes are also deprecated).

The spaceless tag is deprecated in Twig 2.7. Use the spaceless filter instead or {% apply spaceless %} (the Twig\Node\SpacelessNode and Twig\TokenParser\SpacelessTokenParser classes are also deprecated).
@Schyzophrenic
Copy link

This needs to be merged as it prevents this bundle from working on Symfony 4.
I see it hasn't been touched since January, is there any reason for that?

@carlos-mg89
Copy link

@sumuhire I'd be more than happy to accept these and other changes into the fork I've created (and commited to maintain it) so we can all benefit from this.

This is the forked repository link: https://github.com/carlos-mg89/symfony-captcha-bundle

It's published in Packagist and has already been updated so at least the code compiles. But things like the one you're talking about in this PR would most likely be an issue, if not in the short term, in the long term for sure.

@carlos-mg89
Copy link

@sumuhire no worries, I've ended up making a pull request myself, since this was a major issue and the deprecated tag made the twig template to not compile. However, feel free to send PRs if you fancy to improve the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants