Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TreeBuilder use compatible with Symfony 5.0 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make TreeBuilder use compatible with Symfony 5.0 #6

wants to merge 1 commit into from

Conversation

cyrilverloop
Copy link

No description provided.

@carlos-mg89
Copy link

@cyrilverloop I'd be more than happy to take all these PRs you've sent to this repository and merge them into the repository I've just forked and published as a new composer package.

https://github.com/carlos-mg89/symfony-captcha-bundle

It might be a bit too much, but I though that a lot of effort was put into this library and it'd be very sad to let it rotten.

I've already included the related changes that you proposed in this very pull request for the Symfony 5.0 compatibility and have tested it in a project of my own successfully. However, it'd be awesome if you are keen to send these PRs into the forked repository so everyone benefits from those changes.

@cyrilverloop
Copy link
Author

Hi,

Thanks for adding my updates to your fork.
New PRs don't seem necessary.
Is there something else you wanted me to do ?

@carlos-mg89
Copy link

Actually I've included the other PRs as well, since the project wasn't working on Symfony 5 at least.

And I included many more changes to make it fully compatible with Symfony 5. You can check it out if you fancy, I'm already using it in a project of mine and works like a charm.

Feel free to send PRs for additions or fixes. I'd be actively supporting it.

@cyrilverloop
Copy link
Author

Good to know thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants