Added lots of features for enhancing error handling. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when trying to scan URLs on a .txt file in case an URL is malformed or not compatible with urllib it will be skipped instead of stopping the whole scan, and now instead of just being on single exception that always that the issue is the filename there are now more precise exception messages. Plus the scan is now more persistent if it finds any issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when trying to scan URLs on a .txt file in case an URL is malformed or not compatible with urllib it will be skipped instead of stopping the whole scan, and now instead of just being on single exception that always that the issue is the filename there are now more precise exception messages. Plus the scan is now more persistent if it finds any issues.