fix(wallets): trezorCoin returns Connect shortcuts - #530
Conversation
Suite 26.8+ rejects coin names. Return btc/test/regtest so signing works on both current and older Suite.
🦋 Changeset detectedLatest commit: d3ca0b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jpcummins
left a comment
There was a problem hiding this comment.
I ran through the manual Trezor test suite in the following scenarios:
Trezor Suite 26.7.4 without fix to establish baseline compatibility - 6 errors:
- sign testnet transaction w/ 2 outputs and 3 inputs (P2SH)
- sign testnet transaction w/ 2 outputs and 3 inputs (P2SH-P2WSH)
- sign testnet transaction w/ 2 outputs and 3 inputs (P2WSH)
- sign mainnet transaction w/ 2 outputs and 3 inputs (P2SH)
- Confirm testnet P2SH multisig address
- Confirm mainnet P2SH multisig address
Trezor Suite 26.7.4 with fix to test backwards compatibility - 6 errors. No new errors introduced:
- sign testnet transaction w/ 2 outputs and 3 inputs (P2SH)
- sign testnet transaction w/ 2 outputs and 3 inputs (P2SH-P2WSH)
- sign testnet transaction w/ 2 outputs and 3 inputs (P2WSH)
- sign mainnet transaction w/ 2 outputs and 3 inputs (P2SH)
- Confirm testnet P2SH multisig address
- Confirm mainnet P2SH multisig address
Trezor Suite 26.8.2 without fix to confirm additional errors - 1 failure, 8 errors
- sign testnet transaction w/ 2 outputs and 3 inputs (P2SH)
- sign testnet transaction w/ 2 outputs and 3 inputs (P2SH-P2WSH)
- sign testnet transaction w/ 2 outputs and 3 inputs (P2WSH)
- sign mainnet transaction w/ 2 outputs and 3 inputs (P2SH)
- sign mainnet transaction w/ 2 outputs and 3 inputs (P2SH-P2WSH)
- sign mainnet transaction w/ 2 outputs and 3 inputs (P2WSH)
- Confirm testnet P2SH multisig address
- [failure] Confirm testnet P2WSH multisig address
- Confirm mainnet P2SH multisig address
Trezor Suite 26.8.2 with fix to confirm additional errors - 6 errors:
- sign testnet transaction w/ 2 outputs and 3 inputs (P2SH)
- sign testnet transaction w/ 2 outputs and 3 inputs (P2SH-P2WSH)
- sign testnet transaction w/ 2 outputs and 3 inputs (P2WSH)
- sign mainnet transaction w/ 2 outputs and 3 inputs (P2SH)
- Confirm testnet P2SH multisig address
- Confirm mainnet P2SH multisig address
I've confirmed this patch fixes the issue and doesn't introduce any backward incompatibility or other new errors.
Fixes #529
Suite 26.8+ looks up Connect
coinby shortcut only.Bitcoin/Testnet/RegtestthrowMethod_UnknownCoin.trezorCoin()now returnsbtc/test/regtest. Shortcuts still work on 26.7.4.blockchainSetCustomBackendcoin isregtest.Address-confirm copy still says Bitcoin / Testnet / Regtest.
Tests assert
"btc"and"test". No"regtest"assertion becauseTREZOR_DEVis captured at import.@caravan/walletsminor: exportedtrezorCoinreturn values changed. Callers comparing to"Bitcoin"/"Testnet"/"Regtest"need to update.