-
Notifications
You must be signed in to change notification settings - Fork 986
Add adastack.io to showcase #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tuckpuck - sounds interesting, looking forward to checking it out - in the meantime, I would recommend a "zoom in" on your image: considering that the thumbnail image is only about 280px wide and the text wouldn't be readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved all questions from #1456 (review) ... except the image zoom-in which can be done at the contributor's discretion.
Thanks all for the approvals and feedback! Appreciate it. I think the zoom level is fine for now, the heading and subheading is still visible. I plan to change the home page at some point soon anyway, at which point I will submit an updated image with the latest. |
👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.
Checklist
<-- Please fill the boxes with [x] before submitting a pull request -->
yarn build
after adding my changes without getting any errors.yarn.lock
(or have removed these changes).Showcase addition
<-- Provide information for every bullet in the list below. The tags you select must match the tags in your changes to the showcase.js -->
ecosystem
educational