Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(C05_P03): fix flip_bit_to_win solution #221

Merged
merged 1 commit into from
Mar 6, 2022
Merged

fix(C05_P03): fix flip_bit_to_win solution #221

merged 1 commit into from
Mar 6, 2022

Conversation

DJTai
Copy link
Contributor

@DJTai DJTai commented Mar 5, 2022

Ensures max_cnt is set using built-in max() function. Also adds the test case (0b10110110111, 6), which before the fix was returning 5 instead of 6. Tested with pytest, formatted with black.

Ensures `max_cnt` is set using built-in `max()` function. Also
adds a test case.
Copy link
Collaborator

@brycedrennan brycedrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thank you!

@brycedrennan brycedrennan merged commit ec8d61f into careercup:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants