Update p02_check_permutation.py #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't it enough to simply check Counter(str1) == Counter(str2) instead of checking the length? Looks superflous to me. I may be wrong tho.
|
It's a short-circuit using a "cheap" calculation. Length checks are O(1) but if the strings are very long (megabytes) then running |
Cesarsk
added a commit
to Cesarsk/CtCI-6th-Edition-Python
that referenced
this pull request
Aug 17, 2022
added a comment to one of the functions according to careercup#248
brycedrennan
pushed a commit
that referenced
this pull request
Aug 25, 2022
added a comment to one of the functions according to #248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isn't it enough to simply check Counter(str1) == Counter(str2) instead of checking the length? Looks superflous to me. I may be wrong tho.