Update p03_urlify.py #250
Closed
Update p03_urlify.py #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a check. If there aren't at least two 'whitespace' characters at the end of the input_string, the algorithm doesn't work.
i.e. ("Mr Jo", 5) returns %2
brycedrennan
requested changes
Aug 25, 2022
| @@ -5,6 +5,11 @@ | |||
| def urlify_algo(string, length): | |||
| """replace spaces with %20 and removes trailing spaces""" | |||
| # convert to list because Python strings are immutable | |||
|
|
|||
| # there must be at least two trailing spaces for this algorithm to work | |||
| if ord(string[-1]) != ord(string[-2]) != 32: | |||
There was a problem hiding this comment.
This doesn't work since a string may have no spaces. If we did want to enforce this though probably we'd do something like:
if not string.endswith(" "):
raise ValueError("String needs to end with spaces")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a check. If there aren't at least two 'whitespace' characters at the end of the input_string, the algorithm doesn't work.
i.e. ("Mr Jo", 5) returns %2