Update p03_urlify.py #256
Closed
Update p03_urlify.py #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check each char and replace spaces with %20 Time Complexity = o(n)
brycedrennan
requested changes
Dec 18, 2022
| @@ -21,6 +21,21 @@ def urlify_algo(string, length): | |||
| return "".join(char_list[new_index:]) | |||
|
|
|||
|
|
|||
|
|
|||
| def url_Ify(str1,length): | |||
| """ check each char and replace spaces with %20 Time Complexity = o(n) """ | |||
There was a problem hiding this comment.
Appending to strings in python creates a new string every time. So complexity might actually be n^2
| """ check each char and replace spaces with %20 Time Complexity = o(n) """ | ||
|
|
||
| new = '' #create a emtpy string | ||
| for i in range(length): |
There was a problem hiding this comment.
could just be
for c in str1
| @@ -21,6 +21,21 @@ def urlify_algo(string, length): | |||
| return "".join(char_list[new_index:]) | |||
|
|
|||
|
|
|||
|
|
|||
| def url_Ify(str1,length): | |||
There was a problem hiding this comment.
generally should not have numbers in variable names
|
If we fixed this to be O(n) instead of O(n^2) it would look very similar to existing solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check each char and replace spaces with %20 Time Complexity = o(n)