Updated beacon to be its own sampling method#505
Merged
bardram merged 7 commits intocarp-dk:pr503-beacon-scanfrom Jul 25, 2025
Merged
Updated beacon to be its own sampling method#505bardram merged 7 commits intocarp-dk:pr503-beacon-scanfrom
bardram merged 7 commits intocarp-dk:pr503-beacon-scanfrom
Conversation
bardram
approved these changes
Jul 25, 2025
Contributor
bardram
left a comment
bardram
left a comment
There was a problem hiding this comment.
It looks good. I will merge this to my branch and review it. Then also update the documentation and release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new Beacon sampling methods to split the previous implementation.