Conversation
bardram
requested changes
Sep 22, 2025
Contributor
bardram
left a comment
bardram
left a comment
There was a problem hiding this comment.
This does not work at all:
- stuff is hardcoded to the studies app
- need to be one authentication method
- no example in the example app
- no documentation in the README file
…hardcoded strings in request
bardram
requested changes
Oct 2, 2025
Contributor
bardram
left a comment
bardram
left a comment
There was a problem hiding this comment.
- API docs are missing in all places.
- README documentation of how to use the new
authenticateWithMagicLinkendpoint is missing - The demo app needs to be updated to demo the use of
authenticateWithMagicLink
backends/carp_webservices/lib/carp_auth/carp_auth_properties.dart
Outdated
Show resolved
Hide resolved
Panosfunk
force-pushed
the
panosfunk/anonymous-auth
branch
from
64b42d8 to
06fa47e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.