[WIP] Fix variable declaration in JFacePlugin to resolve CI test failures

[Copilot]

Fix JFace Cleanup Test Failures - Plan

• Add missing imports for VariableDeclarationStatement and VariableDeclarationFragment to JFacePlugin.java
• Replace SingleVariableDeclaration with VariableDeclarationFragment + VariableDeclarationStatement (lines 414-432)
• Change replacement target from minv to minv.getParent() to replace the entire ExpressionStatement
• Run tests to verify the fix resolves all 14 test failures
• Validate the generated code matches expected output format

Original prompt

Problem

The CI tests in PR #568 are failing with 14 test failures in sandbox_jface_cleanup_test. The root cause is that JFacePlugin.java uses SingleVariableDeclaration instead of VariableDeclarationStatement when replacing monitor.beginTask() with SubMonitor subMonitor = SubMonitor.convert(...).

Root Cause

In sandbox_jface_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/JFacePlugin.java, lines 414-432, the code creates a SingleVariableDeclaration:

SingleVariableDeclaration newVariableDeclarationStatement = ast.newSingleVariableDeclaration();
newVariableDeclarationStatement.setName(ast.newSimpleName(identifier));
newVariableDeclarationStatement.setType(ast.newSimpleType(addImport(SubMonitor.class.getCanonicalName(), cuRewrite, ast)));
// ...
newVariableDeclarationStatement.setInitializer(staticCall);
ASTNodes.replaceButKeepComment(rewrite, minv, newVariableDeclarationStatement, group);

However, SingleVariableDeclaration is only valid inside method parameter lists or catch clauses - it cannot stand alone as a statement. For a local variable declaration statement like:

SubMonitor subMonitor = SubMonitor.convert(monitor, "Task", 100);

You need to use VariableDeclarationStatement with a VariableDeclarationFragment.

Required Fix

Change the code to use VariableDeclarationStatement instead:

// Create the variable declaration fragment (name + initializer)
VariableDeclarationFragment fragment = ast.newVariableDeclarationFragment();
fragment.setName(ast.newSimpleName(identifier));
fragment.setInitializer(staticCall);

// Create the variable declaration statement (type + fragment)
VariableDeclarationStatement varDeclStmt = ast.newVariableDeclarationStatement(fragment);
varDeclStmt.setType(ast.newSimpleType(addImport(SubMonitor.class.getCanonicalName(), cuRewrite, ast)));

// Replace the entire ExpressionStatement (parent of beginTask), not just the MethodInvocation
ASTNodes.replaceButKeepComment(rewrite, minv.getParent(), varDeclStmt, group);

Key changes:

1. Use VariableDeclarationFragment + VariableDeclarationStatement instead of SingleVariableDeclaration
2. Replace minv.getParent() (the ExpressionStatement) instead of just minv (the MethodInvocation)

Files to Modify

• sandbox_jface_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/JFacePlugin.java

Expected Result

After this fix, the transformation should produce valid Java code that matches the test expectations, and all 14 failing tests should pass.

This pull request was created from Copilot chat.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.