Remove standalone SubProgressMonitor and done() removal from JFace cleanup

[Copilot]

PR #568 introduced two features with scope issues in the AstProcessorBuilder/ReferenceHolder pattern: visitors don't share holder data across Block boundaries, breaking standalone SubProgressMonitor detection and done() call tracking.

Changes

Removed from JFacePlugin.java:

• MonitorHolder fields: isStandalone, doneInvocations, subMonitorVarName
• Standalone SubProgressMonitor visitor logic and post-processing loop
• done() method invocation visitor and removal logic in rewrite()

Removed test cases:

• StandaloneSubProgressMonitor
• StandaloneSubProgressMonitorWithFlags
• DoneCallRemoval
• MultipleDoneCalls

Documentation:

• Updated README to reflect scope: only beginTask + SubProgressMonitor patterns

Retained Functionality

Core transformation remains intact:

• beginTask + SubProgressMonitor → SubMonitor.convert + split
• Flag mapping (SUPPRESS_SUBTASK_LABEL → SUPPRESS_SUBTASK)
• Unique variable name generation
• All 9 original working tests

// Still works correctly
monitor.beginTask("Task", 100);
IProgressMonitor sub = new SubProgressMonitor(monitor, 50);
// → SubMonitor subMonitor = SubMonitor.convert(monitor, "Task", 100);
//   IProgressMonitor sub = subMonitor.split(50);

// No longer handled (requires holder sharing fix)
IProgressMonitor sub = new SubProgressMonitor(monitor, 50);  // standalone
monitor.done();  // removal

Net: -270 lines, stable for merge. Removed features can be revisited after addressing holder pattern limitations.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• www.eclipse.org
  • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/sandbox/sandbox org.codehaus.plexus.classworlds.launcher.Launcher verify -DskipTests -T 1C (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Problem

PR #568 introduced new features for the JFace cleanup plugin that are causing test failures:

1. Standalone SubProgressMonitor handling - Converting SubProgressMonitor instances without a preceding beginTask()
2. done() call removal - Removing redundant monitor.done() calls after conversion

These features have scope function issues with the AstProcessorBuilder and ReferenceHolder pattern, where visitors don't properly share holder data across Block boundaries.

Solution

Simplify the PR scope by removing these problematic features while keeping what works:

Keep (these are working):

• Basic beginTask + SubProgressMonitor → SubMonitor.convert + split transformation
• Flag mapping (SUPPRESS_SUBTASK_LABEL → SUPPRESS_SUBTASK, drop PREPEND_MAIN_LABEL_TO_SUBTASK)
• Unique variable name generation
• All original test cases (PositiveCase, Twice, WithFlags, UniqueVariableName, IdempotenceAlreadyConverted, MixedStateOneConvertedOneNot, NestedInnerClass, LambdaScenario, BothImportsCoexist)

Remove from JFacePlugin.java:

1. Remove the isStandalone field and related logic in MonitorHolder
2. Remove the doneInvocations field and related logic in MonitorHolder
3. Remove the subMonitorVarName field from MonitorHolder
4. Remove the standalone SubProgressMonitor detection and rewrite logic in find() and rewrite()
5. Remove the done() visitor in find() and done() removal logic in rewrite()
6. Remove the allSubProgressMonitors set and post-processing loop in find()

Remove from Java8CleanUpTest.java:

Remove these test cases that test the removed features:

• StandaloneSubProgressMonitor
• StandaloneSubProgressMonitorWithFlags
• SuppressSubtaskLabelFlag (if it tests standalone behavior)
• PrependMainLabelToSubtaskFlag (if it tests standalone behavior)
• DoneCallRemoval
• MultipleDoneCalls

Note: Keep SuppressSubtaskLabelFlag and PrependMainLabelToSubtaskFlag test cases if they test flags with beginTask context (not standalone).

Update README.md:

• Remove documentation about standalone SubProgressMonitor conversion
• Remove documentation about done() call removal
• Keep documentation about flag mapping (SUPPRESS_SUBTASK_LABEL → SUPPRESS_SUBTASK)

Expected Outcome

After this change:

• All remaining tests should pass
• The core functionality (beginTask + SubProgressMonitor → SubMonitor.convert + split) works correctly
• Flag mapping for 3-arg constructors works correctly
• The codebase is stable for merging

The standalone and done() removal features can be revisited in a future PR after investigating the holder sharing pattern in sandbox-common-test.

This pull request was created from Copilot chat.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.