Wip ayushpaharia responsiveness #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guxiaoyang_s20_307 <[email protected]>
Issue:
1. Api "https://api.github.com/user/emails" 不再支持 query params 方式追加 access_token参数;
2. Api "https://api.github.com/user" 不再支持 query params 方式追加 access_token参数;
Resolve:
以上两接口均按 [github 文档-user](https://docs.github.com/en/free-pro-team@latest/rest/reference/users#list-email-addresses-for-the-authenticated-user)改为 在 header 中 添加
- ("Authorization", "token " + access_token);
- ("access", "application/vnd.github.v3+json");
得以解决。
* fixed some typos and pointer * fixed some typos and pointer
Two apis of github oauth changed which cause login failed
Add more details about setting up OAuth application
Signed-off-by: Pranav Kulshrestha <[email protected]>
Aligning the submit button in the add policy page - (Solves - casbin#125)
Signed-off-by: Pranav Kulshrestha <[email protected]>
Signed-off-by: Pranav Kulshrestha <[email protected]>
Center aligning the submit button for the add and edit page - (Solves - casbin#143)
|
@tangyang9464 @closetool @sagilio please review |
|
guxiaoyang_s20_307 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
|
@ayushpaharia plz fix:
|
|
@tangyang9464 @seriouszyx @Steve0x2a @nodece plz review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #114
Description :
Screenshot of changes :
Please ensure Checkmark the following :