Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Application Default Credentials in googlecloud #18

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

notdu
Copy link

@notdu notdu commented Aug 14, 2024

Support default Application Default Credentials when ServiceAccountJson is empty

@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

@notdu
Copy link
Author

notdu commented Aug 14, 2024

hi @hsluoyz, please help me review this PR

@hsluoyz
Copy link
Member

hsluoyz commented Aug 14, 2024

@dacongda

Copy link

@dacongda dacongda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why move oss import to the bottom

googlecloud/googlecloud.go Outdated Show resolved Hide resolved
@hsluoyz hsluoyz changed the title feat: support Application Default Credentials feat: support Application Default Credentials in googlecloud Aug 14, 2024
@hsluoyz hsluoyz merged commit d9cc8ee into casdoor:master Aug 14, 2024
3 checks passed
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants