fix: start nfc redemption on update binary command#207
Closed
a1denvalu3 wants to merge 1 commit intomainfrom
Closed
fix: start nfc redemption on update binary command#207a1denvalu3 wants to merge 1 commit intomainfrom
a1denvalu3 wants to merge 1 commit intomainfrom
Conversation
This ensures the UI reading animation only begins when the reader writes the token (0xD6 instruction), avoiding early triggers on SELECT or READ BINARY.
Collaborator
Author
|
Closing this, because the UX is horrendous. We have this change in #203 , where it is required to make the tap-to-pay work again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UPDATE BINARY(0xD6) APDU command is received.SELECTorREAD BINARYcommands, meaning the animation properly reflects when the tag is actually being written to.