Open
Conversation
- Update CDK to 0.15.2-rc.0 to access `toBech32String` for NUT-26 encoded payment requests. - Add 'Unified' tab alongside Cashu and Lightning tabs. Unselected tabs now visually shrink down to just display their respective icons. - Simplify WebSocket listeners logic to always fetch both Cashu and Lightning payment updates simultaneously in the background. - Construct unified BIP21 URI combining `creq=` and `lightning=` parameters when generating the Unified QR Code and supplying the Unified HCE NDEF tag. - Apply smooth LayoutTransitions when toggling tabs.
…ent UI stutter" This reverts commit 2b55504.
a1denvalu3
force-pushed
the
feat/bip321-uri
branch
from
77458de to
6d60961
Compare
a1denvalu3
force-pushed
the
feat/bip321-uri
branch
from
755b70a to
6aec64c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor payment tabs into a proper segmented control
previously each tab had an icon and a text label, but only one was visible at a time — selecting a tab hid the icon and showed the text. this caused two problems: the container width kept changing (labels are wider than icons), and the
LayoutTransition.CHANGINGwe were using to smooth that over was fighting the layout on every tap.what changed:
LinearLayoutfor aFrameLayoutso we can layer a slidingView(the pill indicator) behind the tab rowlayout_weight=1so they're equal width and the pill width is constant — onlytranslationXneeds to animateObjectAnimatorontranslationX(250ms,FastOutSlowInInterpolator) replaces the background resource swappingArgbEvaluatorcrossfades text colors between white and secondary grayisLaidOutguard +tabContainer.post {}so the indicator is positioned correctly before any tab selection firescontainer is now fixed width (
0dpconstrained with 32dp margins) so it never shifts.unified-example.mp4