Fix: Amount input is not zeroed after successful payment#228
Merged
a1denvalu3 merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
The amount input wasn't properly zeroing out when dismissing the payment success overlay using the hardware back button because onBackPressed() unconditionally called cancelPayment(), which explicitly overwrote the RESULT_OK with RESULT_CANCELED. This caused the caller (ModernPOSActivity) to ignore the success and skip the reset. Now, cancelPayment() and onBackPressed() respect the terminal success state and simply dismiss the success screen without overriding the result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216.
Summary
cancelPayment()andonBackPressed()inPaymentRequestActivityfrom overwritingActivity.RESULT_OKwithActivity.RESULT_CANCELEDif the payment has already succeeded.ModernPOSActivityreceivesRESULT_OKcorrectly and subsequently resets the amount input field.