NUT-XX: Cairo Spending Conditions implementation#1100
Closed
vincentpalma wants to merge 53 commits intocashubtc:mainfrom
Closed
NUT-XX: Cairo Spending Conditions implementation#1100vincentpalma wants to merge 53 commits intocashubtc:mainfrom
vincentpalma wants to merge 53 commits intocashubtc:mainfrom
Conversation
TODO: the test doesnt compile because the under nutxx/example_proof.json was created using the package cairo-prove, which at the latest version still uses an old version of stwo_cairo_prover and stwo_cairo_verifier, but in the project we use the more recent version (we use commit 335de15 but cairo-prove uses commit 62c3c4a). There are two option: 1. modify our project to use older packages 62c3c4a or 2. fork cairo-prove and update the packages to the latest version. I think option 2 would be better since the verify_cairo function doesn't require a PcsConfig in the newer version, which makes things cleaner to use in cashu
Cairo verification working. Tested locally works just fine.
…ified when transformed into memory values...
Program hash verification
feat: output verification using custom tags
…ted `Proof::dummy_prove`
M2 Integration Test
… dependency to starknet_types_core
… for /swap to because to default can't handle cairo proofs
…t Make sure to have a mint running at localhost:8085
…sher from mint-info
This reverts commit 0f0d8d9d197bcf90bcef8e4398b0f33c73cd1a02.
vincentpalma
changed the title
vincentpalma
changed the title
Contributor
|
This PR is stale because it has been open for 60 days with no activity. |
Contributor
|
This PR was closed because it has been inactive for 21 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified mint + cdk-cli wallet with an implementation of the Cairo Spending Conditions NUT.
Notes to the reviewers
We changed the Rust version from stable to nightly because
stwo_cairo_proverrequires some nigthly features. We also had to increase the default body limit for/swapincdk-axumbecauseCairoProof's are typically 10-15mb in size.Before merging:
NUT-XX,nutxx, etc with the proper number.Suggested CHANGELOG Updates
CHANGED
cdk-axum: increased body limit for
/swapbecause of Cairo proof size constraintADDED
cashu: add support for new Cairo Spending Condition
cdk-integration-tests: e2e Cairo Spending Condition test for the mint using a hardcoded program
cdk-cli: add support for new Cairo Spending Condition
cdk-common: add new error types for Cairo
cdk-mintd: add new mint config for nutxx Cairo
REMOVED
FIXED
Checklist
just final-checkbefore committing