bring signatory up to date with the remote signer spec#1257
Merged
thesimplekid merged 17 commits intocashubtc:mainfrom Feb 25, 2026
Merged
bring signatory up to date with the remote signer spec#1257thesimplekid merged 17 commits intocashubtc:mainfrom
thesimplekid merged 17 commits intocashubtc:mainfrom
Conversation
lescuer97
changed the title
lescuer97
force-pushed
the
signatory_up_to_spec
branch
from
e44ec92 to
4e26d87
Compare
Collaborator
|
Are there still open questions on this should we bump it to 0.15? |
vnprc
reviewed
Nov 17, 2025
lescuer97
force-pushed
the
signatory_up_to_spec
branch
from
891ac38 to
473d6c1
Compare
Contributor
Author
Contributor
Author
|
@crodas could you re run the test? I think there was an error |
Collaborator
Its not an error. Cargo.lock file needs to be updated since you added a dep. |
Collaborator
|
@crodas tests are now passing can you review? |
Collaborator
|
Absolutely! |
crodas
previously approved these changes
Jan 9, 2026
2 tasks
3 tasks
lescuer97
force-pushed
the
signatory_up_to_spec
branch
from
ce313d4 to
910582e
Compare
Contributor
Author
|
@thesimplekid rebased. I will do some final tests around compatibility and it should be ready |
crodas
previously approved these changes
Jan 14, 2026
lescuer97
force-pushed
the
signatory_up_to_spec
branch
from
910582e to
9769f00
Compare
Contributor
Author
|
demo of the spec: remote_signer_demo_compresed_free_convert.mp4 |
lescuer97
force-pushed
the
signatory_up_to_spec
branch
from
7e694a8 to
00ae02c
Compare
Contributor
Author
|
adding as reference #1556 (review) |
lescuer97
force-pushed
the
signatory_up_to_spec
branch
from
48a0c6a to
db3eaab
Compare
Contributor
Author
|
Because of interoperability we now send a When the protofile is changed this version should be upped. |
Collaborator
|
@crodas can you review |
crodas
previously approved these changes
Feb 19, 2026
This reverts commit a580025.
lescuer97
force-pushed
the
signatory_up_to_spec
branch
from
702ad0b to
b3b3ffe
Compare
crodas
approved these changes
Feb 25, 2026
thesimplekid
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the signatory keyset generation and updates the proto spec to follow this pr
1- Generates new keysets with the correct derivations paths.
2- returns the derivation_index as version
3- add test vectors from remote signer
Notes to the reviewers
This should not affect any already created keyset.
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing