Open
Conversation
Collaborator
|
This is a good start but I think we need to check that each functions has the needed args that it does not require interactive prompts. For example I think on the mpp branch of melt we do not have the needed args to complete this non-interactively. We also need to work on how the output of the command is handle and how agent friendly that is or could be made, could also be a separate pr. We could even add some tests for this, but I won't require that as part of this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1701
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
Added Non-interactive mode for the cdk-cli
REMOVED
FIXED
Checklist
just final-checkbefore committing