fix: add missing version header to all mint RPC CLI subcommands#1764
Open
gudnuf wants to merge 1 commit intocashubtc:mainfrom
Open
fix: add missing version header to all mint RPC CLI subcommands#1764gudnuf wants to merge 1 commit intocashubtc:mainfrom
gudnuf wants to merge 1 commit intocashubtc:mainfrom
Conversation
The server requires x-cdk-protocol-version header on all RPC requests, but 10 of 12 CLI subcommands were not sending it, causing them to be rejected. Wrap all Request::new() calls with with_version_header().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The server requires
x-cdk-protocol-versionheader on all RPC requests, but 10 of 12 mint RPC CLI subcommands were not sending it. Every CLI command exceptupdate_nut04failed with "Missing x-cdk-protocol-version header". This wraps allRequest::new()calls withwith_version_header().Notes to the reviewers
I asked claude how tsk could forget such a thing to make sure this is actually a bug and I was reassured that he simply forgot.
Suggested CHANGELOG Updates
FIXED
x-cdk-protocol-versionheaderChecklist
just final-checkbefore committing