feat: follow deterministic derivation spec#68
feat: follow deterministic derivation spec#68lescuer97 wants to merge 6 commits intocashubtc:masterfrom
Conversation
| const seed = await this.seedService.getSeed(); | ||
| const hdKey = HDKey.fromMasterSeed(seed); | ||
| const derivationPath = `m/129373'/10'/0'/0'/${nextDerivationIndex}`; | ||
| const derivationPath = `m/129372'/10'/0'/0'/${nextDerivationIndex}`; |
There was a problem hiding this comment.
The derivation path can not simply be changes like that. We need a backwards compatible way, like deriving both paths at the same time and checking proofs against both
There was a problem hiding this comment.
@lescuer97 you marked this as resolved, but I am unable to see how it was resolved.
|
lescuer97
force-pushed
the
derivation_test
branch
from
24663bd to
3dec45c
Compare
|
@Egge21M I'm getting type errors on build but I can't seem to manage to fix this. completely, the same command in my pc is passing correctly. |
|
TBH I am not sure what changed. Maybe we need to pin tsc to stop it from changing under our feet. I have the same problem and fixed it in another PR. Should be merged tomorrow. Then a rebase will fix this |
|
Rebasing to |
lescuer97
force-pushed
the
derivation_test
branch
2 times, most recently
from
913c194 to
640d568
Compare
lescuer97
force-pushed
the
derivation_test
branch
from
331c1b4 to
b4fc2c2
Compare
|
@Egge21M is this ready to be reviewed after the v1 prospection? |
lescuer97
force-pushed
the
derivation_test
branch
from
e091094 to
454026e
Compare
lescuer97
force-pushed
the
derivation_test
branch
from
37dea7c to
6883df6
Compare
Egge21M
left a comment
Egge21M
left a comment
There was a problem hiding this comment.
Thank you @lescuer97 for taking the lead on this one! I might be missing something, but I don't think the concerns about backwards compatibility where addressed in the latest fixes. Also the new bun-sqlite adapter is not wired up.
| const seed = await this.seedService.getSeed(); | ||
| const hdKey = HDKey.fromMasterSeed(seed); | ||
| const derivationPath = `m/129373'/10'/0'/0'/${nextDerivationIndex}`; | ||
| const derivationPath = `m/129372'/10'/0'/0'/${nextDerivationIndex}`; |
There was a problem hiding this comment.
@lescuer97 you marked this as resolved, but I am unable to see how it was resolved.
|
replaced by: #121 |
3 participants
changes the derivation path to be the same as cashubtc/nuts#331