notes on JCO imports #1
Draft
+38
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
commented
Dec 17, 2024
| "plug": "wac plug target/wasm32-wasip1/debug/test-rs.wasm --plug ../typescript/ts-typescript.wasm -o target/test.wasm --plug ../typescript-system/target/wasm32-wasip1/debug/typescript_system.wasm", | ||
| "run": "wasmtime run target/test.wasm a b c" | ||
| "plug": "wac plug target/wasm32-wasip1/debug/test-rs.wasm -o target/test.wasm --plug ../typescript/ts-typescript.wasm", | ||
| "plug2": "wac plug target/test.wasm -o target/test2.wasm --plug ../typescript-system/target/wasm32-wasip1/debug/typescript_system.wasm", |
There was a problem hiding this comment.
You have to plug one at a time. I had to do this for rust-rust-rust as well. Not specific to JCO.
| @@ -17,7 +17,7 @@ | |||
| "componentize": "bunx jco componentize world.js --wit wit -o ts-typescript.wasm -d all" | |||
| }, | |||
| "devDependencies": { | |||
| "@bytecodealliance/jco": "1.8.1", | |||
| "@bytecodealliance/jco": "file:../../jco", | |||
There was a problem hiding this comment.
There is not a release yet that includes this fix:
| @@ -1,15 +1,11 @@ | |||
| // import { TsTypescriptSystemTypes as tssystem } from 'ts-typescript-system-types'; | |||
| // import TsSystem = tssystem.System; | |||
| import { System } from 'ts:typescript-system/types'; | |||
There was a problem hiding this comment.
The name matches the wit name.
| @@ -12,7 +12,7 @@ | |||
| "moduleResolution": "node", | |||
| "baseUrl": ".", | |||
| "paths": { | |||
| "ts-typescript-system-types": ["interfaces/ts-typescript-system-types.d.ts"] | |||
| "ts:typescript-system/types": ["interfaces/ts-typescript-system-types.d.ts"] | |||
There was a problem hiding this comment.
And then here in tsconfig.json, you can say where to find the generated type definition for it. The types are generated by jco types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.