Moodle 501 stable issue63 - #64
Merged
Merged
Conversation
guillogo
force-pushed
the
MOODLE_501_STABLE_issue63
branch
2 times, most recently
from
June 30, 2026 17:44
188703b to
3936c66
Compare
…odle 5.1 The upstream fix (cherry-picked from the 4.0.4 branch) added the required HTML attributes to the section element. However, on Moodle 5.1 the reactive course editor JS also needs to be explicitly initialised on single section pages, since the core template that normally does this is never rendered by the twocol format on that view. Export sectionreturn and pagesectionid from export_for_template() and call component.init() in the single section page template block. Closes #63
guillogo
force-pushed
the
MOODLE_501_STABLE_issue63
branch
from
June 30, 2026 17:51
3936c66 to
8d28c15
Compare
|
Hi @guillogo, Thank you for your work on this issue. Testing passed on Moodle 5.1 environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
The upstream fix (cherry-picked from the 4.0.4 branch, commit e6ea52e)
added the required HTML attributes to the section element but did not
include the JS initialisation call.
On Moodle 5.1, the reactive course editor JS must be explicitly started
on single section pages. The core template that normally does this is
never rendered by the twocol format on that view, so drag and drop was
completely broken on ?section=N pages.
Export sectionreturn and pagesectionid from export_for_template() and
call component.init() in the single section page template block,
matching the same pattern used by the core courseformat content template.