Add support for broken-down intrinsic gas, change execution event gas recording

[kjcamann]

There are several related things happening in this PR. First we add a new C type, for representing the broken-down sources of intrinsic gas cost:

/// Components of intrinsic gas (g_0)
struct monad_c_eth_intrinsic_gas
{
    uint64_t base;           ///< Base cost of transaction
    uint64_t data;           ///< Cost of calldata
    uint64_t creation;       ///< Cost of contract creation
    uint64_t init_code;      ///< Cost of EIP-3860 initcode metering
    uint64_t access_list;    ///< Cost of EIP-2930 access list entries
    uint64_t authorizations; ///< Cost of EIP-7702 authorizations
};

There are a few changes:

• The sole function which computes intrinsic gas (intrinsic_gas_breakdown) now produces one of the above structures. The sum function, whose overload for this type is found via argument dependent lookup, aggregates a breakdown structure to produce the total intrinsic gas; the old intrinsic_gas function is now a convenience wrapper for sum(intrinsic_gas_breakdown<traits>(tx))

• static_validate_transaction no longer computes the intrinsic gas itself, but requires the caller to pass it in. This was done for two reasons (1) it removes a hack for system transactions, where we used to pass a (temporary) fake gas_limit to trick the intrinsic validation step and (2) now we're computing this once and passing it around, no need to keep recomputing it (although sometimes we re-sum it)

• The broken down intrinsic_gas_ is stored in the ExecuteTransaction functor, so that it can be passed in full to the event recording; eventually it will be exposed publicly via both RPC and the exec event ring, but this is an API (for RPC) and ABI (for events) affecting change, so it will happen later

• Top-level call frame gas accounting is changed for execution events; eventually when we break the ABI, we'll report the intrinsic gas breakdown too

[Copilot]

Pull request overview

This PR refactors intrinsic gas computation to support broken-down gas cost reporting and improves execution event gas accounting. It introduces a new C structure monad_c_eth_intrinsic_gas to represent individual components of intrinsic gas costs, refactors static_validate_transaction to accept pre-computed intrinsic gas as a parameter, and updates event recording to correctly handle top-level call frame gas accounting.

Key Changes

• Introduced monad_c_eth_intrinsic_gas struct to break down intrinsic gas into base, data, creation, init_code, access_list, and authorizations components
• Modified static_validate_transaction to accept intrinsic gas as a parameter, eliminating the need for a workaround with system transactions
• Updated top-level call frame gas accounting in execution events to correctly subtract intrinsic gas

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
category/execution/ethereum/core/eth_ctypes.h	Added new monad_c_eth_intrinsic_gas struct definition with component fields
category/execution/ethereum/transaction_gas.hpp	Added declarations for intrinsic_gas_breakdown and sum functions
category/execution/ethereum/transaction_gas.cpp	Refactored intrinsic_gas to use intrinsic_gas_breakdown and added sum function
category/execution/ethereum/validate_transaction.hpp	Updated static_validate_transaction signature to accept intrinsic gas parameter
category/execution/ethereum/validate_transaction.cpp	Modified validation to use passed-in intrinsic gas instead of computing it
category/execution/ethereum/execute_transaction.hpp	Added intrinsic_gas_ member to store breakdown
category/execution/ethereum/execute_transaction.cpp	Updated to compute and store intrinsic gas breakdown, pass it to validation and events
category/execution/monad/execute_system_transaction.cpp	Simplified system transaction validation by passing zero intrinsic gas
category/execution/ethereum/event/record_txn_events.hpp	Updated signature to accept gas_left and intrinsic gas breakdown
category/execution/ethereum/event/record_txn_events.cpp	Improved top-level frame gas accounting using intrinsic gas breakdown
category/rpc/monad_executor.cpp	Updated eth_call to compute and pass intrinsic gas
test/ethereum_test/src/transaction_test.cpp	Updated test to pass intrinsic gas to validation
category/execution/ethereum/test/test_validation.cpp	Updated all validation tests to compute and pass intrinsic gas

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The declaration of the sum function is in the global namespace, but the definition in transaction_gas.cpp (line 166) is inside the monad namespace. This namespace mismatch will cause a linkage error. Either move this declaration inside MONAD_NAMESPACE_BEGIN/END to match the definition, or move the definition in the .cpp file outside the monad namespace to match this declaration.