Open
Conversation
1c3b206 to
fe39dff
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates transaction execution code to properly propagate exceptions from previous transaction futures by changing from wait() to get() on future objects. This ensures that if a previous transaction in the execution sequence throws an exception, it will be properly propagated to dependent transactions rather than silently ignored.
Key changes:
- Replaced
prev_.get_future().wait()withprev_.get_future().get()to enable exception propagation from previous transaction executions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| category/execution/monad/execute_system_transaction.cpp | Updated system transaction execution to use get() instead of wait() for proper exception propagation from previous transaction |
| category/execution/ethereum/execute_transaction.cpp | Updated regular transaction execution to use get() instead of wait() for proper exception propagation from previous transaction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
267ce55 to
5ec6eb4
Compare
5ec6eb4 to
2775944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.