Skip to content

use future.get() to propagate exceptions#1989

Open
andreaslyn wants to merge 1 commit intomainfrom
andreaslyn/future_get
Open

use future.get() to propagate exceptions#1989
andreaslyn wants to merge 1 commit intomainfrom
andreaslyn/future_get

Conversation

@andreaslyn
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 18, 2025 14:10
@andreaslyn andreaslyn force-pushed the andreaslyn/future_get branch from 1c3b206 to fe39dff Compare December 18, 2025 14:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates transaction execution code to properly propagate exceptions from previous transaction futures by changing from wait() to get() on future objects. This ensures that if a previous transaction in the execution sequence throws an exception, it will be properly propagated to dependent transactions rather than silently ignored.

Key changes:

  • Replaced prev_.get_future().wait() with prev_.get_future().get() to enable exception propagation from previous transaction executions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
category/execution/monad/execute_system_transaction.cpp Updated system transaction execution to use get() instead of wait() for proper exception propagation from previous transaction
category/execution/ethereum/execute_transaction.cpp Updated regular transaction execution to use get() instead of wait() for proper exception propagation from previous transaction

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andreaslyn andreaslyn force-pushed the andreaslyn/future_get branch 5 times, most recently from 267ce55 to 5ec6eb4 Compare December 19, 2025 17:32
@andreaslyn andreaslyn force-pushed the andreaslyn/future_get branch from 5ec6eb4 to 2775944 Compare December 19, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants