CLI help text: space-separated paths instead of comma-separated db paths#2015
CLI help text: space-separated paths instead of comma-separated db paths#2015Chen-Yifan wants to merge 1 commit intomainfrom
Conversation
correctly indicate it accepts space-separated database paths instead of comma-separated paths.
There was a problem hiding this comment.
Pull request overview
This PR corrects the CLI help text for the --db option to accurately describe the parameter format. The help text previously stated "comma-separated" but CLI11 (the command-line parsing library used) actually parses vector options as space-separated values by default.
- Updated help text from "comma-separated" to "space-separated" in two CLI applications
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/monad_cli.cpp | Corrected the help text for the --db option to specify "space-separated" instead of "comma-separated" |
| cmd/monad/main.cpp | Corrected the help text for the --db option to specify "space-separated" instead of "comma-separated" |
Review Notes:
The changes in this PR are correct and align with how CLI11 actually parses vector options. CLI11 uses space-separated values by default when parsing options into std::vector types, not comma-separated values. The updated help text now accurately reflects the actual parsing behavior.
I noticed that there are two additional files in the codebase (category/mpt/bench/async_read_bench.cpp and category/mpt/test/read_only_db_stress_test.cpp) that still contain the incorrect "comma-separated" description for similar --db options. While these are outside the scope of this PR, they should be updated in a follow-up for consistency across the codebase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
No description provided.