Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR transitions the magic_enum dependency from a system-provided package to a Git submodule to address availability issues across different Linux distributions.
Changes:
- Added
magic_enumas a Git submodule - Updated CMake configuration to use the submodule instead of
find_package - Removed platform-specific include path handling
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| third_party/magic_enum | Added magic_enum submodule at specific commit |
| scripts/ubuntu-build/install-deps.sh | Removed libmagicenum-dev from package dependencies |
| category/execution/monad/staking/fuzzer/staking_contract_machine.hpp | Simplified include to use single path with submodule |
| CMakeLists.txt | Changed from find_package to add_subdirectory for magic_enum |
| .gitmodules | Registered magic_enum submodule configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Baltoli
approved these changes
Feb 3, 2026
Unlike all the other system-provided third-party libraries, magic enum is not popular enough to be packaged on every distribution.
Baltoli
force-pushed
the
ken/void-compile-pr1
branch
from
6053751 to
acf77d6
Compare
dhil
approved these changes
Feb 12, 2026
jhunsaker
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike all the other system-provided third-party libraries, magic enum is not popular enough to be packaged on every distribution.