feat: add egui 0.34 support - #102
Conversation
|
I assume that some of us are still waiting for this egui 0.34 support to be in place. @Lynnesbian Thanks for the contribution! 馃檹 PS (updated initial message): 鈩癸笍 To others like me: to have this compile (even independently, that is using |
I hit the same. The reason is that the src/themes.rs.tera file exists in the repo which leads build.rs wanting to regenerate src/themes.rs with whiskers which is not available. I "fixed" (well it isnt a bug) it on a fork of the branch Erik1000@ffaa826 |
|
@Erik1000 I had to |
you have to if the file exists. my branch works without whiskers |
Until [this PR](catppuccin/egui#102) gets merged. And now that (mainly as an example) call to `/manifest.json` works using both localhost and 127.0.0.1.
|
Yep, the build script runs unconditionally, which is problematic for people building it themselves from source. I proposed removing the build script in this issue: #97 |
|
Upgrading egui currently seems to require waiting for this crate to support the new version too, even though the theme logic is relatively small. In my own app, I ended up embedding the Catppuccin theme implementation directly into the application code. I wonder if there is a better way to make this less tightly coupled to egui versions. |
This PR is very similar to #96. I tested it by modifying the todo example, but didn't commit those changes for the same reason @philpax didn't last time.
I've also updated
lib.rsto avoid a deprecation warning onContext::style: