Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home-manager): init fzf module #93

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

Anomalocaridid
Copy link
Contributor

Adds support for fzf.

I took the same approach that the console module uses and used the palette to manually add the colors from catppuccin/fzf.

"bg+" = "surface0";
bg = "base";
spinner = "rosewater";
hl = "red";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: group hl with hl+ and the same for fg and fg+ like you did for bg and bg+

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that, but first I should mention I put the options in that specific order to match the (seemingly arbitrary) order of the options in catppuccin/fzf to make it easier to compare.

Copy link
Member

@isabelroses isabelroses Mar 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, that makes total sense, I think its fine to leave it as is then.

@getchoo
Copy link
Member

getchoo commented Apr 7, 2024

this needs a rebase

@Anomalocaridid
Copy link
Contributor Author

Rebased

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@getchoo getchoo merged commit b08e480 into catppuccin:main Apr 10, 2024
2 checks passed
@Anomalocaridid Anomalocaridid deleted the fzf branch April 10, 2024 12:05
Liassica pushed a commit to Liassica/ctp-nix that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants