Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(brave-search): theme ask a follow-up question field #1639

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

kovabait12
Copy link
Contributor

@kovabait12 kovabait12 commented Feb 27, 2025

🔧 What does this fix? 🔧

Themes the "Ask a follow-up question" text field.

🗒 Checklist 🗒

@kovabait12 kovabait12 requested a review from ndsboy as a code owner February 27, 2025 10:10
@github-actions github-actions bot added the brave-search Brave Search label Feb 27, 2025
@uncenter
Copy link
Member

Please review the contributing guidelines linked under the checkbox you checked off in the pull request template. The title of your pull request needs to be formatted like every other pull request, following the conventional commit standard. Your changes should also go in a related part of the userstyle, and not at the very top with the list of our default styles. Adding it toward the bottom is usually a safer bet.

@uncenter uncenter marked this pull request as draft February 27, 2025 11:11
@kovabait12
Copy link
Contributor Author

Please review the contributing guidelines linked under the checkbox you checked off in the pull request template. The title of your pull request needs to be formatted like every other pull request, following the conventional commit standard. Your changes should also go in a related part of the userstyle, and not at the very top with the list of our default styles. Adding it toward the bottom is usually a safer bet.

will do

@kovabait12 kovabait12 changed the title Update catppuccin.user.less fix(brave-search): theme ask a follow-up question field Feb 27, 2025
@kovabait12 kovabait12 marked this pull request as ready for review February 27, 2025 11:35
- remove svelte selector as this seems generated
- increase version
@uncenter
Copy link
Member

@ndsboy you actually don't need to (shouldn't, even!) update the version. That is done automatically by the CI pipeline after merge (see aaa67de for example).

@ndsboy
Copy link
Contributor

ndsboy commented Feb 28, 2025

@uncenter thanks, didn't know that :)

Copy link
Contributor

@ndsboy ndsboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@uncenter
Copy link
Member

@uncenter thanks, didn't know that :)

Yeah no problem. Meant to make it so you can forget about updating it entirely ahah (along with the move to calendar versioning in the first place), it was an unnecessary step from earlier in the repository's history.

@uncenter
Copy link
Member

approved

Feel free to merge since you are the maintainer of the userstyle being fixed :)

@ndsboy ndsboy merged commit a8020dd into catppuccin:main Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brave-search Brave Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants