Color picker slider#1823
Merged
RodriSanchez1 merged 14 commits intocboard-org:masterfrom Apr 28, 2025
Merged
Conversation
Contributor
|
@KevinDussel we tested the code with @RodriSanchez1 and did a review, the branch works well. I suggest these actions: /*add the follow option in colorSchemes:*/
colorSchemes[
{'custom'}
]create a flag that detects when it's selected and shows them. |
Color picker slider
Colorpicker color first state
gonojuarez
approved these changes
Apr 9, 2025
Contributor
gonojuarez
left a comment
There was a problem hiding this comment.
the function works well
Contributor
Author
marginTop added
… color handling logic
…eamline color handling
RodriSanchez1
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Just added the HuePicker doing the less modifications possible

like the picture of Martin,
in the pr already existent 1787 they add all the box of color picker being bigger than what we need,
Just let me know!
close #1771