Make stored account activation transactional#169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth.jsonand active account metadata if activation cannot complete/loginstored-account switching prepare credentials under a rollback guard and defer active-account metadata until the replacement session startsRefs #160
Validation
just fmtjust test -p codex-login auth_accountsjust test -p codex-tui login_slash_command_stored_account_selection_switches_accountjust fix -p codex-loginjust fix -p codex-tui(scoped; unrelated auto-fix churn reverted)cargo insta pending-snapshots --manifest-path tui/Cargo.tomlinspect-closeout --scope changed_files: green, 0 actionable findingsNotes
just fmtcurrently prints existingexclude-newer = "7 days"TOML parse warnings from Python formatter discovery, but completed and ran Rustfmt.