Harden JetBrains inspection proof verdicts#390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens the JetBrains inspection helper against false-green readiness results by making compact proof failures override a plugin/helper
GREENverdict, and by preserving nested.ideaproject paths as exact route targets instead of collapsing them to the parent git worktree.What changed
proof_failuresas verdict-source data copied through summaries.UNKNOWNwithinspection_proof_failedwhen proof contradictions are present, even if the plugin saysGREENandtotal_problemsis0..ideaproject paths inbuild_context()asproject_path/exact_route_path.exact_route_pathfor route sorting, route diagnostics, and exact route verification..idearouting, proof-failure summary propagation, and human verdict behavior.Validation
Refs cbusillo/jetbrains-inspection-api#113
Refs cbusillo/jetbrains-inspection-api#114
Refs #388