Separate artifact publish from deployment secrets#86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failure Evidence
CM workflow run
29626583285failed before build with tracelaunchplane_req_568fa32b9add4111bbeca7301917bc05because devkit requiredODOO_MASTER_PASSWORD,ODOO_DB_USER, andODOO_DB_PASSWORD. Launchplane's artifact-input route intentionally returned onlyODOO_VERSIONand base image inputs. No deployment occurred.Validation
uv run python -m unittest tests.test_runtime— 98 passeduv run python -m unittest discover -s tests— 214 passed, 1 skippeduv run ruff check --no-fix .uv run ruff format --check .uv builduv run platform --helpAfter merge, the exact failed CM main-branch artifact workflow will be retried. Success is required before closing #85.
Refs #85