Skip to content

issues Search Results · repo:cdevents/sdk-java language:Java

Filter by

34 results
 (78 ms)

34 results

incdevents/sdk-java (press backspace or delete to remove)

Implement context schema validation for all the events by using in-memory schema cache or downloading from internet with an option to user as per comment, https://github.com/cdevents/sdk-java/pull/83#discussion_r1674226053 ...
  • rjalander
  • Opened 
    on Jul 15, 2024
  • #84

0.3.0 was published with Java 11 bytecode $ jarviz bytecode show --gav dev.cdevents:cdevents-sdk-java:0.3.0 subject: cdevents-sdk-java-0.3.0.jar Unversioned classes. Bytecode version: 53 (Java 9) total: ...
released
  • aalmiray
  • 1
  • Opened 
    on Feb 14, 2024
  • #77

$ unzip -l cdevents-sdk-java-0.3.0.jar | grep json No matches. This means schema files cannot be found.
released
  • aalmiray
  • 1
  • Opened 
    on Feb 13, 2024
  • #72

The current code foe each event loads its schema in this way https://github.com/cdevents/sdk-java/blob/3055c23edd1e056a3b7fd9c682e24b80d1f4e862/sdk/src/main/java/dev/cdevents/events/PipelinerunStartedCDEvent.java#L102-L108 ...
released
  • aalmiray
  • 2
  • Opened 
    on Feb 13, 2024
  • #71

Right now model classes do not override these methods making, equals, a little more complicated. Lombok can make this easy.
  • xibz
  • 6
  • Opened 
    on Jan 5, 2024
  • #68

Currently all objects in the SDK are mutable. If a new event or object is needed, it should be recreated, instead of using setters to set things. https://github.com/cdevents/sdk-java/blob/5d17b750fda57fd4a9d7ad2c5baec2bb4b9e2143/sdk/src/main/java/dev/cdevents/models/build/started/Subject.java#L113-L115 ...
  • xibz
  • 1
  • Opened 
    on Jan 5, 2024
  • #67

When constructing objects, we can freely change them whenever via the setters. I would not to not allow for this and go with a more immutable approach.
  • xibz
  • 1
  • Opened 
    on Jan 5, 2024
  • #66

If a field is required, then we should enforce it in the constructor or when calling build (if we have a builder). https://github.com/cdevents/sdk-java/blob/5d17b750fda57fd4a9d7ad2c5baec2bb4b9e2143/sdk/src/main/java/dev/cdevents/models/build/started/Subject.java#L23-L29 ...
  • xibz
  • 1
  • Opened 
    on Jan 5, 2024
  • #65

Subject classes for build events do not have a proper parent. For example https://github.com/cdevents/sdk-java/blob/5d17b750fda57fd4a9d7ad2c5baec2bb4b9e2143/sdk/src/main/java/dev/cdevents/models/build/queued/Subject.java#L21 ...
  • xibz
  • 1
  • Opened 
    on Jan 5, 2024
  • #64

Create a test to validate the event class files generated by generator/pom.xml The number of class files and names generated by generator/pom.xml should match with the number of schema files under sdk-java ...
  • rjalander
  • 2
  • Opened 
    on Nov 30, 2023
  • #61
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub