SHA-3 code changes for verification#1482
Open
karthikbhargavan wants to merge 1 commit into
Open
Conversation
Reorganize the NEON (arm64) and AVX2 SIMD backends from monolithic
files into per-concern submodules:
simd/arm64.rs -> simd/arm64/{wrappers,load,store}.rs (+ mod shim)
simd/avx2.rs -> simd/avx2/{wrappers,load,store}.rs (+ mod shim)
- wrappers: math wrappers + the KeccakItem<N> impl (and the arm64
`uint64x2_t` type alias, re-exported from the shim).
- load: load_block, load_last, and the Absorb<N> impl.
- store: store_block and the Squeeze{2,4} impl.
Pure code move: function bodies are unchanged. The SIMD backends are
excluded from the portable hax extraction, so the F* extraction is
byte-for-byte identical and the sha3-hax CI (extract/lax/type-check)
is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some code refactorings we had to do to simplify the proofs for SHA-3, specifically to avoid individual code+proof files from getting too big.
[skip changelog]