add Jenkinsfile for build ci pipeline#542
Open
fpichler wants to merge 4 commits into
Open
Conversation
msladek
requested changes
Jun 13, 2026
msladek
reviewed
Jun 21, 2026
msladek
approved these changes
Jun 23, 2026
|
|
||
| const localDev = | ||
| options.localDev ?? (import.meta.env.VITE_ENABLE_LOCAL_DEVELOPMENT ?? 'true') === 'true'; | ||
| options.localDev ?? appConfig.enableLocalDevelopment; |
Member
There was a problem hiding this comment.
wouldnt it be simpler to use import.meta.env.DEV (true in npm run dev) instead of a local config value?
|
|
||
| # cel access | ||
| VITE_CEL_USER= | ||
| VITE_CEL_TOKEN= |
Member
There was a problem hiding this comment.
could we remove .env.celdev and .env.celint? appConfig should be the preferred configuration mechanism. env- or node-specific values belong on the target nodes, not in this public code repo.
for local configuration:
cp config.sample.js public/config.js && vim public/config.js
Comment on lines
+12
to
+16
| appBaseUrl: '$(escape_js_string "${APP_BASE_URL:-}")', | ||
| keycloakBaseUrl: '$(escape_js_string "${KEYCLOAK_BASE_URL:-}")', | ||
| keycloakRealm: '$(escape_js_string "${KEYCLOAK_REALM:-}")', | ||
| keycloakClientId: '$(escape_js_string "${KEYCLOAK_CLIENT_ID:-}")', | ||
| keycloakClientSecret: '$(escape_js_string "${KEYCLOAK_CLIENT_SECRET:-}")', |
Member
There was a problem hiding this comment.
Suggested change
| appBaseUrl: '$(escape_js_string "${APP_BASE_URL:-}")', | |
| keycloakBaseUrl: '$(escape_js_string "${KEYCLOAK_BASE_URL:-}")', | |
| keycloakRealm: '$(escape_js_string "${KEYCLOAK_REALM:-}")', | |
| keycloakClientId: '$(escape_js_string "${KEYCLOAK_CLIENT_ID:-}")', | |
| keycloakClientSecret: '$(escape_js_string "${KEYCLOAK_CLIENT_SECRET:-}")', | |
| appBaseUrl: '$(escape_js_string "${APP_BASE_URL}")', | |
| keycloakBaseUrl: '$(escape_js_string "${KEYCLOAK_BASE_URL}")', | |
| keycloakRealm: '$(escape_js_string "${KEYCLOAK_REALM}")', | |
| keycloakClientId: '$(escape_js_string "${KEYCLOAK_CLIENT_ID}")', | |
| keycloakClientSecret: '$(escape_js_string "${KEYCLOAK_CLIENT_SECRET}")', |
mandatory fields should fast fail if unset (sh strict mode) to prevent config errors.
| @@ -0,0 +1,22 @@ | |||
| #!/bin/sh | |||
| set -eu | |||
Member
There was a problem hiding this comment.
Suggested change
| set -eu | |
| set -euo pipefail |
POSIX.1-2024 specification added support for pipefail, so it is fine in sh files.
Comment on lines
+13
to
+17
| const appBaseUrl = appConfig.appBaseUrl; | ||
| const authBaseUrl = appConfig.keycloakBaseUrl; | ||
| const realm = appConfig.keycloakRealm; | ||
| const clientId = appConfig.keycloakClientId; | ||
| const clientSecret = appConfig.keycloakClientSecret; |
Member
There was a problem hiding this comment.
Suggested change
| const appBaseUrl = appConfig.appBaseUrl; | |
| const authBaseUrl = appConfig.keycloakBaseUrl; | |
| const realm = appConfig.keycloakRealm; | |
| const clientId = appConfig.keycloakClientId; | |
| const clientSecret = appConfig.keycloakClientSecret; | |
| const { appBaseUrl, authBaseUrl, realm, clientId, clientSecret } = appConfig.appBaseUrl; |
|
|
||
| # Layer: dependencies | ||
| COPY package*.json ./ | ||
| RUN npm install --legacy-peer-deps |
|
|
||
| # End of https://www.toptal.com/developers/gitignore/api/java,linux,macos,maven,eclipse,windows,visualstudiocode,node | ||
|
|
||
| celements-admin-frontend/public/config.js |
Member
There was a problem hiding this comment.
Suggested change
| celements-admin-frontend/public/config.js | |
| **/public/config.js |
more frontends will likely follow :)
msladek
reviewed
Jun 24, 2026
Member
There was a problem hiding this comment.
use newly available dockerImagePipeline in with mode: 'node'
e.g.: https://github.com/progonline/progon-apps/blob/dev/event-webform/event-webform-frontend/Jenkinsfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Jenkinsfile for build CI pipeline and align environment profiles
Description
This PR introduces a declarative
Jenkinsfileat the root of the repository to build and push thecelements-admin-frontendDocker image to the GitHub Container Registry (ghcr.io). It also introduces theceldevenvironment profile and aligns/updates the integration environment configuration.Proposed Changes
Jenkins Pipeline
Jenkinsfile:7.1) as well as the short Git SHA.ghcr-credentialsare configured in Jenkins for authorization withghcr.io.Environment Configurations (
celements-admin-frontend).env.celdev:celdevprofile pointing tohttps://bellis.celdev.sneakapeek.chand Keycloak realmceldev..env.int➡️.env.celint:celintnaming standard.VITE_CEL_API_URLto point to thedemospace.chdomain:https://bellis.celint.demospace.ch(previously pointed tosneakapeek.ch).