-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Celeritas cmake command wrappers for downstream code #1678
Conversation
Test summary 4 291 files 6 548 suites 13m 38s ⏱️ Results for commit dfdd793. ♻️ This comment has been updated with latest results. |
This reverts commit 7b60a3c.
30f06e9
to
3b201c7
Compare
Since |
|
Oh I see, that is what you meant when you mentioned |
4a558a9
to
c11cf19
Compare
e056d0e
to
8223b55
Compare
@esseivaju I'm going to add another quick follow-on to fix the perfetto installation. @pcanal could you give this a quick lookover? |
This reverts commit 737a2d9. I guess we do have to export them for static builds...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…roject#1678) * Reapply "Move and always install celeritas library wrappers" * Fix MPI build * Fix typo, use more foolproof way * We *do* need to export object libraries * Fix copy-paste error
* Reapply "Move and always install celeritas library wrappers" * Fix MPI build * Fix typo, use more foolproof way * We *do* need to export object libraries * Fix copy-paste error
…roject#1678) * Reapply "Move and always install celeritas library wrappers" * Fix MPI build * Fix typo, use more foolproof way * We *do* need to export object libraries * Fix copy-paste error
…roject#1678) * Reapply "Move and always install celeritas library wrappers" * Fix MPI build * Fix typo, use more foolproof way * We *do* need to export object libraries * Fix copy-paste error
…roject#1678) * Reapply "Move and always install celeritas library wrappers" * Fix MPI build * Fix typo, use more foolproof way * We *do* need to export object libraries * Fix copy-paste error
This follow-on to #1673 restores and automatically exposes
celeritas_
-prefixed wrappers for downstream applications: