Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pin package tzdata anymore #2274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

stollero
Copy link

@stollero stollero commented Mar 26, 2025

Hello everyone,

I think we can safely upgrade tzdata to newer versions and do not require a version pin, because it is just a timezone database.

This will help other projects upgrading their dependencies without running into dependency conflicts.

Thanks

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm bit reluctant to allow this right atm. may be we can reach a consensus later. until then lets hold it.

@mrcljx
Copy link

mrcljx commented Mar 29, 2025

Would really appreciate if Kombu wasn't dictating dependencies. Best practices for apps and libraries differ.

Using ==2025.2 claims "this library is known to not work with any other version" which is quite definitive (same goes for typing_extensions btw). Pandas is a good citizen and uses tzdata>=2022.7 for example.

@mrcljx
Copy link

mrcljx commented Mar 29, 2025

^ Actually, there's an open issue #2277 about the pinning of typing_extensions

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (9e1c5f1) to head (728db3e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2274   +/-   ##
=======================================
  Coverage   81.60%   81.60%           
=======================================
  Files          77       77           
  Lines        9540     9540           
  Branches     1162     1162           
=======================================
  Hits         7785     7785           
  Misses       1563     1563           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tzdata is a timezone database that should always be upgradeable, otherwise other projects will run into dependency conflicts
@jamesmyatt
Copy link

Pinning exact versions especially for libraries (rather than applications) doesn't work with Python's dependency management. It's a practice that comes from Javascript, which has an entirely different system. See https://iscinumpy.dev/post/bound-version-constraints/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants