docs: add go doc

celestiaorg · Jul 19, 2024 · 2cab538 · 2cab538
1 parent c4ae12c
commit 2cab538
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/pkg/proof/proof_test.go b/pkg/proof/proof_test.go
@@ -147,6 +147,13 @@ func TestNewShareInclusionProof(t *testing.T) {
 			namespaceID:   appns.TxNamespace,
 			expectErr:     true,
 		},
+		{
+			name:          "ending share is equal to the starting share",
+			startingShare: 1,
+			endingShare:   1,
+			namespaceID:   appns.TxNamespace,
+			expectErr:     true,
+		},
 		{
 			name:          "ending share higher than number of shares available in square size of 32",
 			startingShare: 0,

diff --git a/pkg/proof/querier.go b/pkg/proof/querier.go
@@ -123,13 +123,14 @@ func QueryShareInclusionProof(_ sdk.Context, path []string, req abci.RequestQuer
 
 // ParseNamespace validates the share range, checks if it only contains one namespace and returns
 // that namespace ID.
+// The provided range, defined by startShare and endShare, is end-exclusive.
 func ParseNamespace(rawShares []shares.Share, startShare, endShare int) (appns.Namespace, error) {
 	if startShare < 0 {
 		return appns.Namespace{}, fmt.Errorf("start share %d should be positive", startShare)
 	}
 
-	if endShare < 0 {
-		return appns.Namespace{}, fmt.Errorf("end share %d should be positive", endShare)
+	if endShare <= startShare {
+		return appns.Namespace{}, fmt.Errorf("end share %d cannot be lower or equal to the starting share %d", endShare, startShare)
 	}
 
 	if endShare < startShare {