Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: single node script (#929) #2102

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 13, 2023

fixes a left pver --ethereum-address

(cherry picked from commit eb5fe09)

Overview

Cherry pick eb5fe09

Fixes: #2101

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

fixes a left pver `--ethereum-address`

(cherry picked from commit eb5fe09)
@rach-id rach-id requested review from rootulp and cmwaters July 13, 2023 18:37
@rach-id rach-id self-assigned this Jul 13, 2023
@rach-id rach-id added the x/qgb label Jul 13, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sweexordious !

@rach-id
Copy link
Member Author

rach-id commented Jul 13, 2023

Apparently, we can't merge without Evan. Or I don't have enough permissions

@rootulp
Copy link
Collaborator

rootulp commented Jul 14, 2023

Screenshot 2023-07-14 at 9 55 30 AM

lol yea that's odd, I think this PR will remain blocked on Evan's review potentially b/c it's a protected branch (v0.11.x). Maybe this is a good forcing function to get more ppl added as code owners.

@cmwaters
Copy link
Contributor

Maybe this is a good forcing function to get more ppl added as code owners.

Yeah although it's probably quite unusual that we will need to backport something to a branch like v0.11.x

@cmwaters
Copy link
Contributor

cc @evan-forbes when you're available

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moar codeowners

@rach-id rach-id merged commit 9d8b113 into celestiaorg:v0.11.x Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants